[ovs-dev] [PATCH 2/6 RFC] openflow-1.4: Add OFPTYPE_ROLE_STATUS message type

[Ben Pfaff]

On Tue, Oct 08, 2013 at 12:26:19PM +0300, Alexandru Copot wrote:
> Signed-off-by: Alexandru Copot <alex.mihai.c at gmail.com>
> Cc: Daniel Baluta <dbaluta at ixiacom.com>

Thanks for the patch.

I'd just use "struct ofp14_role_status, uint8_t[][8]" as the type here:
> +    /* OFPT 1.4+ (30): uint32_t, uint8_t, uint8_t[3], uint64_t, struct ofp14_role_prop_header[]. */
> +    OFPRAW_OFPT14_ROLE_STATUS,
> +
>  /* Standard statistics. */
>  
>      /* OFPST 1.0+ (0): void. */
> @@ -496,6 +499,9 @@ enum ofptype {
>      /* Meters and rate limiters configuration messages. */
>      OFPTYPE_METER_MOD,            /* OFPRAW_OFPT13_METER_MOD. */
>  
> +    /* Controller role change event messages. */
> +    OFPTYPE_ROLE_STATUS,          /* OFPRAW_OFPT14_ROLE_STATUS. */
> +
>      /* Statistics. */
>      OFPTYPE_DESC_STATS_REQUEST,      /* OFPRAW_OFPST_DESC_REQUEST. */
>      OFPTYPE_DESC_STATS_REPLY,        /* OFPRAW_OFPST_DESC_REPLY. */

Thanks,

Ben.