[ovs-dev] [PATCH 6/6 RFC] lib/ofp-print: add support for printing role status messages

[Ben Pfaff]

On Tue, Oct 08, 2013 at 02:29:50PM -0700, Ben Pfaff wrote:
> On Tue, Oct 08, 2013 at 12:26:23PM +0300, Alexandru Copot wrote:
> > Signed-off-by: Alexandru Copot <alex.mihai.c at gmail.com>
> > Cc: Daniel Baluta <dbaluta at ixiacom.com>
> 
> Thanks for the patch.
> 
> ofp_print_role_status_message() duplicates the code for printing a
> role that is already found in ofp_print_role_message().  Please factor
> it out somehow.
> 
> ofp_print_role_status_message() assert-fails if 'reason' is not valid,
> but I don't think the decode routine initializes (or checks) 'reason'.

Oh, also, could you add a test case in tests/ofp-print.at?

Thanks,

Ben.