[ovs-dev] [PATCH] ovsdb-idl: Remove write-only member 'commit_seqno' from ovsdb_idl_txn.

Ben Pfaff blp at nicira.com
Tue Oct 8 22:13:14 UTC 2013


Applied, thanks.

On Tue, Oct 08, 2013 at 12:44:55PM -0700, Jarno Rajahalme wrote:
> Looks good,
> 
>   Jarno
> 
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> On Aug 14, 2013, at 3:30 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > lib/ovsdb-idl.c      |    2 --
> > python/ovs/db/idl.py |    1 -
> > 2 files changed, 3 deletions(-)
> > 
> > diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
> > index 116aa86..4631291 100644
> > --- a/lib/ovsdb-idl.c
> > +++ b/lib/ovsdb-idl.c
> > @@ -91,7 +91,6 @@ struct ovsdb_idl_txn {
> >     char *error;
> >     bool dry_run;
> >     struct ds comment;
> > -    unsigned int commit_seqno;
> > 
> >     /* Increments. */
> >     const char *inc_table;
> > @@ -1242,7 +1241,6 @@ ovsdb_idl_txn_create(struct ovsdb_idl *idl)
> >     txn->error = NULL;
> >     txn->dry_run = false;
> >     ds_init(&txn->comment);
> > -    txn->commit_seqno = txn->idl->change_seqno;
> > 
> >     txn->inc_table = NULL;
> >     txn->inc_column = NULL;
> > diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py
> > index 55fbcba..a01701a 100644
> > --- a/python/ovs/db/idl.py
> > +++ b/python/ovs/db/idl.py
> > @@ -733,7 +733,6 @@ class Transaction(object):
> >         self._status = Transaction.UNCOMMITTED
> >         self._error = None
> >         self._comments = []
> > -        self._commit_seqno = self.idl.change_seqno
> > 
> >         self._inc_row = None
> >         self._inc_column = None
> > -- 
> > 1.7.10.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list