[ovs-dev] [PATCH] monitor: Fix improper use of stubs.

[Ethan Jackson]

I can't reproduce the failure, are you still seeing it?

Ethan

On Thu, Oct 10, 2013 at 9:07 PM, Ethan Jackson <ethan at nicira.com> wrote:
> Looking into it, should have checked before merging.
>
> Ethan
>
> On Thu, Oct 10, 2013 at 9:05 PM, Simon Horman <horms at verge.net.au> wrote:
>> Curiously, making the stub non-static seems to break
>> at least the first two tests of the test-suite.
>> I assume its exposing a bug but I haven't investigated further.
>>
>> On Thu, Oct 10, 2013 at 06:18:17PM -0700, Ethan Jackson wrote:
>>> Oops didn't notice that it was.  I'll change it before merging.
>>>
>>> Ethan
>>>
>>> On Thu, Oct 10, 2013 at 6:02 PM, Ben Pfaff <blp at nicira.com> wrote:
>>> > On Thu, Oct 10, 2013 at 05:57:51PM -0700, Ethan Jackson wrote:
>>> >> Stubs must be uninitialized when used in case they allocate memory.
>>> >>
>>> >> Signed-off-by: Ethan Jackson <ethan at nicira.com>
>>> >
>>> > Also, stubs shouldn't ordinarily be static, any particular reason the
>>> > one here is?
>>> >
>>> > Acked-by: Ben Pfaff <blp at nicira.com>
>>> >
>>> _______________________________________________
>>> dev mailing list
>>> dev at openvswitch.org
>>> http://openvswitch.org/mailman/listinfo/dev
>>>