[ovs-dev] [PATCH 2/4] connmgr: Use 'ofproto_mutex' to protect ofconns from being destroyed.
Ben Pfaff
blp at nicira.com
Fri Oct 11 16:09:02 UTC 2013
On Fri, Oct 11, 2013 at 08:58:20AM -0700, Ethan Jackson wrote:
> I guess the only thing I'm wondering about is how you know when
> ofproto_mutex is required and when it isn't. In particular, why do we
> need to hold it for the entire connmgr_set_controllers()? That's not
> totally clear from the comment at the top of the file.
I don't think we need to hold it for the entire
connmgr_set_controllers(). I could probably narrow it, if you like. It
was a little easier to keep it for the entire span of the function and I
didn't think it would be a big deal because it's held for long times
elsewhere during flow mods etc.
> Acked-by: Ethan Jackson <ethan at nicira.com>
More information about the dev
mailing list