[ovs-dev] [PATCH 1/5] ovsdb-dot: Include arrows by default.

Ben Pfaff blp at nicira.com
Sat Oct 12 00:22:42 UTC 2013


On Fri, Oct 11, 2013 at 05:20:22PM -0700, Justin Pettit wrote:
> On Oct 11, 2013, at 5:00 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Fri, Oct 11, 2013 at 04:56:22PM -0700, Justin Pettit wrote:
> >> From: Ben Pfaff <blp at nicira.com>
> >> 
> >> When ovsdb-dot generates diagrams for use in the manpages, the dot2pic
> >> postprocessor makes nicer output if the arrowheads are omitted (dot2pic
> >> adds the arrowheads itself).  But for other uses that don't go through
> >> the postprocessor, we generally want the arrowheads.  So this commit adds
> >> an option.  On the principle that the default should be the least
> >> surprising to a naive user, arrowheads are included by default.
> >> 
> >> Signed-off-by: Ben Pfaff <blp at nicira.com>
> >> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> > 
> > Are you planning to review this?  I wrote it, so I shouldn't.
> 
> You wrote it so long ago that you'd probably do a better job
> reviewing it than me.  However, for the sake of appearances, I'll go
> ahead an review it.  :-)

I wrote so long ago I could really rip into the asshat who wrote it ;-)



More information about the dev mailing list