[ovs-dev] [PATCH v3 net-next] openvswitch: fix vport-netdev unregister

[Jesse Gross]

On Sun, Oct 13, 2013 at 8:50 PM, Alexei Starovoitov <ast at plumgrid.com> wrote:
> diff --git a/net/openvswitch/dp_notify.c b/net/openvswitch/dp_notify.c
> index c323567..ffa429a 100644
> --- a/net/openvswitch/dp_notify.c
> +++ b/net/openvswitch/dp_notify.c
> @@ -59,15 +59,9 @@ void ovs_dp_notify_wq(struct work_struct *work)
>                         struct hlist_node *n;
>
>                         hlist_for_each_entry_safe(vport, n, &dp->ports[i], dp_hash_node) {
> -                               struct netdev_vport *netdev_vport;
> -
>                                 if (vport->ops->type != OVS_VPORT_TYPE_NETDEV)
>                                         continue;
> -
> -                               netdev_vport = netdev_vport_priv(vport);
> -                               if (netdev_vport->dev->reg_state == NETREG_UNREGISTERED ||
> -                                   netdev_vport->dev->reg_state == NETREG_UNREGISTERING)
> -                                       dp_detach_port_notify(vport);
> +                               dp_detach_port_notify(vport);

Doesn't this free *all* ports of type OVS_VPORT_TYPE_NETDEV when any
one of them is removed?