[ovs-dev] [PATCH v2 1/2] meta-flow: Implement mf_force_prereqs().

Ben Pfaff blp at nicira.com
Tue Oct 15 16:43:09 UTC 2013


On Tue, Oct 15, 2013 at 09:19:51AM -0700, Jarno Rajahalme wrote:
> Sets mask bits for the given field and its prerequisite fields.
> Needed for unwildcarding the proper bits from datapath masks.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

I still think that MFP_VLAN_VID doesn't have any mask prereqs,
e.g. instead of this:
    case MFP_ARP:
    case MFP_IPV4:
    case MFP_IPV6:
    case MFP_MPLS:
    case MFP_VLAN_VID:
    case MFP_IP_ANY:
        mask->dl_type = OVS_BE16_MAX;
        /* Fall through. */
    case MFP_NONE:
        break;
this:
    case MFP_ARP:
    case MFP_IPV4:
    case MFP_IPV6:
    case MFP_MPLS:
    case MFP_IP_ANY:
        mask->dl_type = OVS_BE16_MAX;
        /* Fall through. */
    case MFP_VLAN_VID:
    case MFP_NONE:
        break;

Otherwise:
Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list