[ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source
Ben Pfaff
blp at nicira.com
Wed Oct 16 16:13:14 UTC 2013
On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote:
> On 10/16/13 1:17 PM, Simon Horman wrote:
> >This alters the way rx packets are accounted for by
> >counting them when they are processed by netdev_dummy_rx_recv(),
> >which seems to be a common path used by all received packets.
> >
> >Previously accounting was done earlier, in netdev_dummy_receive(),
> >however this does not appear to count packets that are received via
> >a socket.
> >
> >This resolves packet counting errors reported by the following
> >OFtest tests:
> >
> > port_stats.MultiFlowStats
> > port_stats.SingleFlowStats
>
> I confirm that the above OFtests are passed on my (similar) setup as
> well with the below patch.
>
> > pktact.WildcardPriorityWithDelete
> > pktact.WildcardPriority
>
> These tests didn't fail on my setup, but the following two which
> did, are now "ok":
> counters.RxBytPerPort
> counters.RxPktPerPort
Thanks for confirming. Regardless of the tests it fixes, I'm happy that
it fixes them ;-)
More information about the dev
mailing list