[ovs-dev] [PATCH] Fix packet-in reason for OpenFlow1.3 table-miss flow entries

Ben Pfaff blp at nicira.com
Wed Oct 16 16:37:46 UTC 2013


On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote:
> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow
> entries no_match rather than action.
> 
> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

Thanks!  I really appreciate that you are working on conformance to
later OpenFlow specs.

Before I apply this, let me propose a different idea.  I think that your
approach is valid and will work, but it seems to me that it relies on
the ofproto-provider implementation keeping track of where the packet-in
came from.  Another way would be to notice, when we decode the flow_mod
that adds the flow to the flow table, that the flow_mod is for a
catch-all flow, and then mark any packet_in ofpacts in the flow_mod as
ones that should generate table_miss messages.  Then the
ofproto-provider would not have to do anything special, beyond properly
passing along a value from the ofpact.

What do you think?

Thanks,

Ben.



More information about the dev mailing list