[ovs-dev] [PATCH] oftest: Update default controller port number to match recent OFTest.

Simon Horman horms at verge.net.au
Thu Oct 17 00:23:53 UTC 2013


Yes, looks good to me too.

Reviewed-by: Simon Horman <horms at verge.net.au>

On Wed, Oct 16, 2013 at 08:12:39PM +0300, Lori Jakab wrote:
> Looks good to me, thanks for fixing!
> 
> On 10/16/13 7:28 PM, Ben Pfaff wrote:
> >Also, document how to work around it if you use an older OFTest.
> >
> >Reported-by: Simon Horman <horms at verge.net.au>
> >Reported-by: Lori Jakab <lojakab at cisco.com>
> >Signed-off-by: Ben Pfaff <blp at nicira.com>
> >---
> >  README-OFTest    |    7 +++++++
> >  tests/run-oftest |    2 +-
> >  2 files changed, 8 insertions(+), 1 deletion(-)
> >
> >diff --git a/README-OFTest b/README-OFTest
> >index 1b8516b..cdca06d 100644
> >--- a/README-OFTest
> >+++ b/README-OFTest
> >@@ -50,6 +50,13 @@ default) and enable verbose logging:
> >      make check-oftest OFT=<oft-binary> OFTFLAGS='--verbose -T basic.Echo'
> >+If you use OFTest that does not include commit 4d1f3eb2c792 (oft:
> >+change default port to 6653), merged into the OFTest repository in
> >+October 2013, then you need to add an option to use the IETF-assigned
> >+controller port:
> >+
> >+    make check-oftest OFT=<oft-binary> OFTFLAGS='--port=6653'
> >+
> >  Interpreting OFTest Results
> >  ---------------------------
> >diff --git a/tests/run-oftest b/tests/run-oftest
> >index d12a22f..c73c25c 100755
> >--- a/tests/run-oftest
> >+++ b/tests/run-oftest
> >@@ -74,7 +74,7 @@ for port in p1 p2 p3 p4; do
> >                                 options:pstream=punix:$OVS_RUNDIR/$port
> >  done
> >  run ovs-vsctl \
> >-    -- set-controller br0 tcp:127.0.0.1 \
> >+    -- set-controller br0 tcp:127.0.0.1:6653 \
> >      -- set controller br0 connection-mode=out-of-band max-backoff=1000
> >  # Run OFTest.
> 



More information about the dev mailing list