[ovs-dev] [PATCH 1/5] ovsdb-dot: Include arrows by default.

Ben Pfaff blp at nicira.com
Thu Oct 17 20:49:19 UTC 2013


On Thu, Oct 17, 2013 at 01:47:43PM -0700, Justin Pettit wrote:
> On Oct 11, 2013, at 5:00 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Fri, Oct 11, 2013 at 04:56:22PM -0700, Justin Pettit wrote:
> >> From: Ben Pfaff <blp at nicira.com>
> >> 
> >> When ovsdb-dot generates diagrams for use in the manpages, the dot2pic
> >> postprocessor makes nicer output if the arrowheads are omitted (dot2pic
> >> adds the arrowheads itself).  But for other uses that don't go through
> >> the postprocessor, we generally want the arrowheads.  So this commit adds
> >> an option.  On the principle that the default should be the least
> >> surprising to a naive user, arrowheads are included by default.
> >> 
> >> Signed-off-by: Ben Pfaff <blp at nicira.com>
> >> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> > 
> > Are you planning to review this?  I wrote it, so I shouldn't.
> 
> Oh, I did fix a documentation issue between when you wrote it and I
> pulled it over, so you may want to do a quick sanity-check on
> "--no-arrows".

You really are trying to get me to review my own code, aren't you?

It looks OK to me, thanks.



More information about the dev mailing list