[ovs-dev] [PATCH] configure: check for uuid python module

[Ben Pfaff]

On Thu, Oct 17, 2013 at 10:02:30PM -0700, Ansis Atteka wrote:
> After introducing commit a5ae88ff8a276e86c842ac102145432662bf711a
> "ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is
> available" Open vSwitch did not build anymore on hosts that did not
> have uuid python module installed (for example, we still support
> XenServer that still uses old python 2.4 and hence does not have uuid).
> 
> After this commit ./configure will check whether uuid module is present
> and, if it isn't, then it will add python/compat to the PYTHONPATH.
> 
> Signed-Off-By: Ansis Atteka <aatteka at nicira.com>
> Issue: 20476

Acked-by: Ben Pfaff <blp at nicira.com>

One might write this:

> +if INCLUDE_PYTHON_COMPAT
> +run_python = \
> +	PYTHONDONTWRITEBYTECODE=yes \
> +	PYTHONPATH=$(top_srcdir)/python:$(top_srcdir)/python/compat:$$PYTHONPATH \
> +	$(PYTHON)
> +else
>  run_python = \
>  	PYTHONDONTWRITEBYTECODE=yes \
>  	PYTHONPATH=$(top_srcdir)/python:$$PYTHONPATH \
>  	$(PYTHON)
> +endif

with less redundancy as:

if INCLUDE_PYTHON_COMPAT
run_python = PYTHONPATH=$(top_srcdir)/python:$(top_srcdir)/python/compat:$$PYTHONPATH
else
run_python = PYTHONPATH=$(top_srcdir)/python:$$PYTHONPATH
fi
run_python += PYTHONDONTWRITEBYTECODE=yes $(PYTHON)

but either way will work.