[ovs-dev] [PATCH v2 01/15] ofp-actions: Make union ofp_action more generic.

Ben Pfaff blp at nicira.com
Wed Oct 23 20:27:54 UTC 2013


On Wed, Oct 23, 2013 at 11:02:54AM -0700, Jarno Rajahalme wrote:
> 
> On Oct 23, 2013, at 9:46 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Tue, Oct 22, 2013 at 05:20:39PM -0700, Jarno Rajahalme wrote:
> >> Make union ofp_action more generic by allowing it to be used for
> >> all actions.  OFP_ACTION_ALIGN (which is 8, as the sizeof(union
> >> ofp_action) used to be) is now used where sizeof union ofp_action
> >> was used before.  On the same note, variable name 'n_actions' is
> >> changed to 'max_actions' as the number of actions cannot be simply
> >> divided when actions have various sizes.
> >> 
> >> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> > 
> > I think that this pointer arithmetic in ofpacts_from_openflow() is now
> > wrong:
> >            log_bad_action(in, n_in, a - in, error);
> 
> Oops, would you be happy with this incremental:

Almost, yes, with the minor exception that 't' is the right modifier
for ptrdiff_t.

It looks like you reposted the series so I'll apply the new version
and make that change myself.

Thanks a lot!



More information about the dev mailing list