[ovs-dev] [PATCH v3 03/11] OF 1.1 set vlan vid/pcp compatibility.

[Ben Pfaff]

That's OK, but can you fill me in on what tipped the scales toward
single actions?

On Wed, Oct 23, 2013 at 03:02:23PM -0700, Jarno Rajahalme wrote:
> I actually had different ofpacts for these, but then decided to
> ditch them, so if you do not insist, I'd rather not bring em back
> :-)
> 
>   Jarno
> 
> 
> > On Oct 23, 2013, at 2:53 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> >> On Wed, Oct 23, 2013 at 12:52:58PM -0700, Jarno Rajahalme wrote:
> >> OpenFlow 1.1 set vlan actions only modify existing vlan
> >> headers, while OF 1.0 actions push a new vlan header if one
> >> does not exist already.
> >> 
> >> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> > 
> > Do you have a feeling whether the OF1.0 and OF1.1 actions in this
> > space are different enough that they deserve separate ofpacts?  I
> > guess the form of this patch suggests that the answer is "no", but if
> > you had not considered it yet, then please do.