[ovs-dev] [PATCH v3 05/11] Inline mf_from_id(), add OXM names.

Ben Pfaff blp at nicira.com
Wed Oct 23 23:23:00 UTC 2013


On Wed, Oct 23, 2013 at 12:53:00PM -0700, Jarno Rajahalme wrote:
> mf_from_id accesses a static table, so the compiler should be able to
> completely optimize it away.
> 
> Add OXM inspired names to fields that don't have them (e.g., "ip_proto" and
> "ip_dscp", which is nicer than "nw_tos_shifted").
> 
> Fix MFF_IP_DSCP_SHIFTED bit width to 6.
> 
> Also use OVS_PACKED_ENUM to waste less space.Summary:Summary:
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

This commit makes some changes that are not user-visible, such as
moving mf_from_id() into the header, and some that are (adding new
names for fields).  I would prefer to do those in separate patches.

I never meant for nw_tos_shifted to be a user-visible name, and so it
is intentionally not documented.  But if we are inventing a new and
more user-friendly name for it, then perhaps we should document the
new name.  I think that we can drop the old name at the same time (and
then we'll need to update at least one test that uses the old name).

Thanks,

Ben.



More information about the dev mailing list