[ovs-dev] [PATCH 1/3] ofproto: report correct errors for unsupported stats/multipart messages

[YAMAMOTO Takashi]

> On Wed, Oct 23, 2013 at 03:04:21PM +0900, YAMAMOTO Takashi wrote:
>> the correct error in that case is OFPERR_OFPBRC_BAD_STAT,
>> not OFPERR_OFPBRC_BAD_TYPE.
>> 
>> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> 
> If there existed a statistics request that handle_openflow__() couldn't
> handle, then I agree that OFPERR_OFPBRC_BAD_STAT would be the right
> error message.  But that is not the case here, because all of the stats
> messages that this change affects are stats *replies*.  The issue that
> the switch reports when it receives a stats reply is not that it doesn't
> understand that kind of statistic, it is that the switch is receiving
> any kind of statistic reply at all, hence OFPERR_OFPBRC_BAD_TYPE.

thanks for review.

actually, there is such a request.  ie. OFPTYPE_TABLE_FEATURES_STATS_REQUEST
but i agree that bad_type makes more sense for replies.
i posted the updated patch.

YAMAMOTO Takashi

> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev