[ovs-dev] [PATCH 2/3] Delete groups in ofproto_destruct.

Simon Horman horms at verge.net.au
Mon Sep 2 01:30:00 UTC 2013


On Sun, Sep 01, 2013 at 06:24:39PM -0700, Ben Pfaff wrote:
> On Sat, Aug 31, 2013 at 02:11:39PM +0900, Simon Horman wrote:
> > On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote:
> > > Also, since all kinds of groups can refer to other groups, there is no
> > > reason to delete indirect groups first.
> > 
> > This seems reasonable to me, but its not clear to me
> > how the code prevents the deletion of groups that
> > are still referenced either by other groups or by rules.
> 
> I think we might have some problems there.  I'm not sure that this patch
> made it worse, though.

Agreed.

Reading over the OpenFlow 1.3.2 spec it seems that it is optional to
restrict deletion of groups that are in use. So to make our lives easier we
may want to not enforce that restriction at this stage.



More information about the dev mailing list