[ovs-dev] [PATCH v2 02/13] datapath: Move kernel version check to configure.

[Jesse Gross]

On Tue, Sep 3, 2013 at 1:59 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
> diff --git a/acinclude.m4 b/acinclude.m4
> index 73ee5ce..e754cfa 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -134,9 +134,17 @@ AC_DEFUN([OVS_CHECK_LINUX], [
>      AC_MSG_RESULT([$kversion])
>
>      if test "$version" -ge 3; then
> -       : # Linux 3.x
> +       if test "$patchlevel" -le 10; then
> +          : # Linux 3.x
> +       else
> +         AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 3.10.x is not supported])
> +       fi

I think this will allow kernels with a major version greater than 3 as
long as the minor version is less than our target.

>      elif test "$version" = 2 && test "$patchlevel" -ge 6; then
> -       : # Linux 2.6.x
> +       if test "$sublevel" -le 31; then
> +         AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version 2.6.32 or later is required])
> +       else
> +         : # Linux 2.6.x
> +       fi
>      else
>         if test "$KBUILD" = "$KSRC"; then
>           AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version 2.6 or later is required])

Should we fold these two conditions together (less than 2.6.32 and
less than 2.6)? Is it worth having the KSRC == KBUILD check in the
earlier messages?