[ovs-dev] [PATCH] ofproto-dpif: Removed unused struct facet 'hmap_node' member.

Ben Pfaff blp at nicira.com
Wed Sep 4 20:34:16 UTC 2013


Thanks, applied to master.  I skipped branch-2.0 since this doesn't
fix a bug.

On Tue, Sep 03, 2013 at 03:40:54PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson <ethan at nicira.com>
> 
> 
> On Tue, Sep 3, 2013 at 3:39 PM, Ben Pfaff <blp at nicira.com> wrote:
> > This member is not used anywhere for anything.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  ofproto/ofproto-dpif.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> > index 820ec34..9721e9c 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -205,8 +205,7 @@ static void subfacet_uninstall(struct subfacet *);
> >   * Flow expiration works in terms of subfacets, so a facet must have at
> >   * least one subfacet or it will never expire, leaking memory. */
> >  struct facet {
> > -    /* Owners. */
> > -    struct hmap_node hmap_node;  /* In owning ofproto's 'facets' hmap. */
> > +    /* Owner. */
> >      struct ofproto_dpif *ofproto;
> >
> >      /* Owned data. */
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list