[ovs-dev] [PATCH v3 09/13] datapath: Cleanup netlink compat code.

Jesse Gross jesse at nicira.com
Wed Sep 4 20:46:05 UTC 2013


On Wed, Sep 4, 2013 at 12:56 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
> diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
> index 9562d38..7763169 100644
> --- a/lib/netlink-socket.c
> +++ b/lib/netlink-socket.c
> @@ -945,10 +943,6 @@ nl_lookup_genl_mcgroup(const char *family_name, const char *group_name,
>      }
>
>      if (!family_attrs[CTRL_ATTR_MCAST_GROUPS]) {
> -        *multicast_group = fallback;
> -        VLOG_WARN("%s-%s: has no multicast group, using fallback %d",
> -                  family_name, group_name, *multicast_group);
> -        error = 0;
>          goto exit;
>      }

Won't this return 0 if we don't get anything back? It looks to me like
we return EPROTO in other situations in this function if we don't find
the group we are looking for.



More information about the dev mailing list