[ovs-dev] [RFC PATCH] ofproto: update flow_stats flags on flow_stats_request

[Daniel Baluta]

On Mon, Sep 9, 2013 at 1:58 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Sun, Sep 08, 2013 at 02:21:25AM +0300, Daniel Baluta wrote:
>> This is a first step in implementing 'on demand flow counters'.
>> We save flow_mod flags into newly created rule when a new flow
>> is added, and echo them back in the flow stats request.
>>
>> Signed-off-by: Daniel Baluta <dbaluta at ixiacom.com>
>
> It's a reasonable approach.  Two comments:
>
>         * Some of the flags apply to the request, not to the flow.
>           Specifically, I don't think that it makes sense to save the
>           OFPUTIL_FF_CHECK_OVERLAP or OFPUTIL_FF_RESET_COUNTS flags with
>           the flow.

Good point. I will only set only OFPUTIL_FF_NO_PKT_COUNTS and
OFPUTIL_FF_NO_BYT_COUNTS flags.

>
>         * If we save the flags this way, then we don't need the
>           send_flow_removed member anymore because it just reflects the
>           status of the OFPUTIL_FF_SEND_FLOW_REM flag.

I will send v2 asap. Thanks for reviewing this.

Daniel.