[ovs-dev] [PATCH] ofproto: Fix core dump due to uninitialized cls_rule.

Ethan Jackson ethan at nicira.com
Tue Sep 10 20:31:17 UTC 2013


Bug #19568.
Signed-off-by: Ethan Jackson <ethan at nicira.com>
---
 ofproto/ofproto.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index e7ee60e..a9a20b8 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -1290,7 +1290,6 @@ ofproto_run(struct ofproto *p)
             struct oftable *table = &p->tables[i];
             struct eviction_group *evg;
             struct cls_cursor cursor;
-            struct cls_rule cr;
             struct rule *rule;
 
             if (!table->eviction_fields) {
@@ -1302,7 +1301,7 @@ ofproto_run(struct ofproto *p)
             }
 
             ovs_rwlock_rdlock(&table->cls.rwlock);
-            cls_cursor_init(&cursor, &table->cls, &cr);
+            cls_cursor_init(&cursor, &table->cls, NULL);
             CLS_CURSOR_FOR_EACH (rule, cr, &cursor) {
                 if (!rule->eviction_group
                     && (rule->idle_timeout || rule->hard_timeout)) {
-- 
1.7.9.5




More information about the dev mailing list