[ovs-dev] [PATCH] ofproto-dpif: Don't hold mac rwlock while calling send_packet().
Ethan Jackson
ethan at nicira.com
Tue Sep 10 20:59:14 UTC 2013
Not too worried about it.
Thanks for the review,
Ethan
On Tue, Sep 10, 2013 at 1:47 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Sep 06, 2013 at 12:53:17PM -0700, Ethan Jackson wrote:
>> Holding the mac learning rwlock while calling send_packet() which
>> calls xlate_actions() is dangerous because somewhere deep in the chain
>> the same lock might be acquired causing a deadlock. Though we haven't
>> run into this problem in testing, it seems prudent to refactor it.
>>
>> Reported-by: Ben Pfaff <blp at nicira.com>
>> Signed-off-by: Ethan Jackson <ethan at nicira.com>
>
> I guess it seems a little inefficient memorywise, but probably good
> enough.
>
> Acked-by: Ben Pfaff <blp at nicira.com>
More information about the dev
mailing list