[ovs-dev] [threaded-learning 09/25] ofproto: Remove soon-to-be-invalid optimizations.

Ben Pfaff blp at nicira.com
Wed Sep 11 20:45:26 UTC 2013


On Wed, Sep 11, 2013 at 01:20:19PM -0700, Ethan Jackson wrote:
> In ofproto_add_flow().  If the rule already exists and you re-add it,
> are you supposed to tweak any state about it?  I.E. update it's
> created time or something?

Yes, one must do this for flow table modifications that come in via
OpenFlow.  These don't, and the in-band and fail-open modules that
call in don't care, so it's possible to optimize.

> Patch looks nice thanks.
> 
> Acked-by: Ethan Jackson <ethan at nicira.com>

Thanks,

Ben.



More information about the dev mailing list