[ovs-dev] [reordering 5/7] ofproto-dpif: Avoiding unnecessarily counting packets.

[Ben Pfaff]

Thanks for the reviews.  I applied patches 1 to 5 to master and
backported patch 1 to branch-2.0.

I'll figure out what's up with patch 6 now.

On Tue, Sep 17, 2013 at 12:25:50PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> On Sep 16, 2013, at 2:59 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > ofproto/ofproto-dpif.c |    4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> > index 01299e1..80874b8 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -3241,7 +3241,7 @@ flow_miss_should_make_facet(struct flow_miss *miss)
> > 
> >     hash = flow_hash_in_wildcards(&miss->flow, &miss->xout.wc, 0);
> >     return governor_should_install_flow(backer->governor, hash,
> > -                                        list_size(&miss->upcalls));
> > +                                        miss->stats.n_packets);
> > }
> > 
> > /* Handles 'miss', which matches 'facet'.  May add any required datapath
> > @@ -3319,7 +3319,7 @@ handle_flow_miss(struct flow_miss *miss, struct flow_miss_op *ops,
> > {
> >     struct facet *facet;
> > 
> > -    miss->ofproto->n_missed += list_size(&miss->upcalls);
> > +    miss->ofproto->n_missed += miss->stats.n_packets;
> > 
> >     facet = facet_lookup_valid(miss->ofproto, &miss->flow);
> >     if (!facet) {
> > -- 
> > 1.7.10.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>