[ovs-dev] [PATCH] ofproto-dpif: Move special upcall handling into ofproto-dpif-upcall.

Ben Pfaff blp at nicira.com
Tue Sep 24 22:57:05 UTC 2013


On Tue, Sep 24, 2013 at 03:54:24PM -0700, Ethan Jackson wrote:
> > Another way to handle these upcalls might be to uniformly send every
> > packet to a handler thread, and then handle all the kinds of upcalls
> > in the handlers.  Did you consider that solution?  I don't know,
> > off-hand, whether it is better.  It might do less work in the
> > dispatcher, allowing the dispatcher to pass packets to the handlers
> > more quickly.
> 
> I suppose so, but it's not totally clear which handler thread should
> have the honor.  I think this approach is simple, and either way it
> doesn't matter once the dispatcher goes away.

You can't use exactly the same code to choose a handler as for other
upcalls?

It's not worth quibbling since you're planning to kill the dispatcher
anyhow.



More information about the dev mailing list