[ovs-dev] [PATCH] ofproto-dpif: Move special upcall handling into ofproto-dpif-upcall.

Ben Pfaff blp at nicira.com
Tue Sep 24 23:07:31 UTC 2013


On Tue, Sep 24, 2013 at 03:56:02PM -0700, Ethan Jackson wrote:
> Both the IPFIX and SFLOW modules are thread safe, so there's no
> particular reason to pass them up to the main thread.  Eliminating
> this step significantly simplifies the code.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

This commit removes upcall_next() but comments on enum upcall_type
still refer to it.

handle_ipfix_upcall() has the same comment twice.

You mentioned off-list you were going to revise this so I stopped
reviewing after noticing those points.



More information about the dev mailing list