[ovs-dev] [PATCH] Suppress warnings about unused variables and functions.
Ben Pfaff
blp at nicira.com
Thu Sep 26 03:16:10 UTC 2013
On Wed, Sep 25, 2013 at 05:14:18PM -0700, Jarno Rajahalme wrote:
> Using the latest clang I get a lot of warnings about unused variables
> and functions. After a while it becomes difficult to locate genuine
> warnings, so it is best to bet rid of these.
>
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
Thanks! Most of these look good to me at first glance.
The ones in which you added (void)THIS_MODULE should instead be fixed by
removing #include "vlog.h" and VLOG_DEFINE_THIS_MODULE earlier in the
file. (The warning is telling you that nothing actually uses the vlog
module, so there's no point in having one.)
In ofp-actions.c I would tag the functions with OVS_UNUSED instead of
adding the void casts.
I would prefer to use OVS_UNUSED in vlandev.c also. I want to compile
all the code there, where possible, to make it harder to screw up the
stub code.
More information about the dev
mailing list