[ovs-dev] [PATCH] ovs-dpctl, ofproto/trace: Show and handle the in_port name in flows.

[Ben Pfaff]

On Mon, Sep 30, 2013 at 03:11:17PM -0700, Gurucharan Shetty wrote:
> On Mon, Sep 30, 2013 at 2:20 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Wed, Sep 25, 2013 at 12:55:43AM -0700, Gurucharan Shetty wrote:
> >> With this commit, whenever the verbosity is enabled with '-m'
> >> option, the ovs-dpctl dump-flows command will display the flows with
> >> in_port field showing the name instead of a port number.
> >>
> >> Conversely, one can also use a name in the in_port field with del-flow,
> >> add-flow and mod-flow commands of ovs-dpctl. One should also be able
> >> to use the port name when supplying the datapath flow as an input
> >> to ofproto/trace command.
> >>
> >> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
> >
> > Does ofproto_unixctl_trace() leak its port_names simap?
> Yes, it does.
> 
> I plan to add the following incremental.

Thanks, that looks fine.

> > Would you mind refining this comment to something like "A map from odp
> > port number to name." so that it's clear what the main direction of the
> > mapping is?
> Done.

Thanks!