[ovs-dev] [PATCH 2/5] ofpbuf: Introduce access api for base, data and size.

Jarno Rajahalme jrajahalme at nicira.com
Wed Apr 2 19:43:10 UTC 2014


LGTM,

Some lines are too long now.

One more thought: Maybe the code would look cleaner, if “getters” were spelled without the “get”, like “ofpbuf_size()”, “ofpbuf_l2()”. I know it would not rhyme with the “setters”, but as we do much less setting than getting it would still be cleaner? Thoughts?

  Jarno

Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

On Mar 31, 2014, at 9:43 PM, Pravin <pshelar at nicira.com> wrote:

> From: Pravin Shelar <pshelar at nicira.com>
> 
> These functions will be used by later patches.  Following patch
> does not change functionality.
> 
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140402/152ca5a0/attachment-0005.html>


More information about the dev mailing list