[ovs-dev] [PATCH 2/5] ofpbuf: Introduce access api for base, data and size.

Pravin Shelar pshelar at nicira.com
Wed Apr 2 21:35:44 UTC 2014


On Wed, Apr 2, 2014 at 12:43 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> LGTM,
>
> Some lines are too long now.
>
> One more thought: Maybe the code would look cleaner, if "getters" were
> spelled without the "get", like "ofpbuf_size()", "ofpbuf_l2()". I know it
> would not rhyme with the "setters", but as we do much less setting than
> getting it would still be cleaner? Thoughts?
>

I agree, I updated patch and pushed it.

>   Jarno
>
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
>
> On Mar 31, 2014, at 9:43 PM, Pravin <pshelar at nicira.com> wrote:
>
> From: Pravin Shelar <pshelar at nicira.com>
>
> These functions will be used by later patches.  Following patch
> does not change functionality.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> ...



More information about the dev mailing list