[ovs-dev] [PATCH] ofproto-dpif-upcall: Expire netflow flow when revalidate_ukey failed

YAMAMOTO Takashi yamamoto at valinux.co.jp
Thu Apr 3 07:54:01 UTC 2014


> On 3 April 2014 10:16, Joe Stringer <joestringer at nicira.com> wrote:
> 
>> I had noticed that this logic was in the codepath for when we delete a
>> flow from the datapath, but not in this codepath. Thanks for picking this
>> up!
>>
> 
> On second thought, I suppose that this means that we will expire the
> netflow immediately when we discover that the flow is invalid, rather than
> when we delete the flow. How does this impact netflow logging for traffic
> on the flow between the time that the flow is revalidated up until the flow
> is deleted?

i'm not sure if i understand what you mean.

the only caller of revalidate_ukey looks like the following.

        if (!revalidate_ukey(udpif, udump, ukey)) {
            dpif_flow_del(udpif->dpif, udump->key, udump->key_len, NULL);
            ukey_delete(revalidator, ukey);
        }

ie. "when we discover that the flow is invalid" (revalidate_ukey returns false)
and "when we delete the flow" (dpif_flow_del) are almost same.

ideally we should use stats from dpif_flow_del, though.
do you mean this?

YAMAMOTO Takashi



More information about the dev mailing list