[ovs-dev] [PATCH 5/5] ofproto-dpif.at: Sprinkle --overwrite-pidfile

Ben Pfaff blp at nicira.com
Fri Apr 4 15:15:19 UTC 2014


On Fri, Apr 04, 2014 at 05:24:10PM +0900, YAMAMOTO Takashi wrote:
> > On Tue, Apr 01, 2014 at 09:41:49PM +0900, YAMAMOTO Takashi wrote:
> >> >> On Mon, Mar 31, 2014 at 03:24:31PM +0900, YAMAMOTO Takashi wrote:
> >> >>> These tests invokes ovs-ofctl monitor twice or more.
> >> >>> Because "ovs-appctl -t ofctl exit" does not wait for the target
> >> >>> process exit, there are chances to see the pid file from the previous
> >> >>> incarnation.
> >> >>> 
> >> >>> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> >> >> 
> >> >> Good catch.
> >> >> 
> >> >> As an alternative, one could OVS_WAIT_UNTIL the pidfile disappears.
> >> > 
> >> > it sounds like a better solution.  i'll take a look.
> >> > 
> >> > YAMAMOTO Takashi
> >> 
> >> here's a patch.
> >> 
> >> i guess someone familiar with m4 can create
> >> OVS_APP_EXIT_AND_WAIT(appname) macro.
> > 
> > I think that it is as simple as this, but I have not tested it:
> 
> thanks.
> i tested it and folded into the patch.
> is it appropriate to put your Co-authered-by?

If you think I made a valuable contribution, feel free.



More information about the dev mailing list