[ovs-dev] Commit "ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary" breaks test 700

[Lori Jakab]

Hi,

On some of my systems the commit "0c47331 ofproto-dpif.at: Wait for the 
monitor's pidfile disappears where necessary" consistently breaks test 
"700: ofproto-dpif - controller".  Reverting the commit makes the test 
pass again.  This happens on a physical machine (Sandy Bridge laptop 
with Linux).  On a VM, the test passes consistently, regardless of this 
commit.

The relevant output from the test failure below (a lot of output snipped 
for readability):


testsuite.log
-------------

./ofproto-dpif.at:993: cat ofctl_monitor.log
--- -   2014-04-07 10:49:04.066638516 +0300
+++ 
/home/moriarty/src/openvswitch/tests/testsuite.dir/at-groups/700/stdout 
2014-04-07 10:49:04.063659109 +0300
@@ -2,6 +2,4 @@
  mpls,metadata=0,in_port=0,vlan_tci=0x0000,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912
  NXT_PACKET_IN (xid=0x0): cookie=0xa total_len=64 in_port=1 (via 
action) data_len=64 (unbuffered)
  mpls,metadata=0,in_port=0,vlan_tci=0x0000,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912
-NXT_PACKET_IN (xid=0x0): cookie=0xa total_len=64 in_port=1 (via action) 
data_len=64 (unbuffered)
-mpls,metadata=0,in_port=0,vlan_tci=0x0000,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912


ovs-vswitchd.log
----------------

2014-04-07T07:49:03.947Z|00182|vconn|DBG|unix: sent (Success): 
NXT_PACKET_IN (xid=0x0): cookie=0xa total_len=64 in_port=1 (via action) 
data_len=64 (unbuffered)
mpls,metadata=0,in_port=0,vlan_tci=0x0000,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912
2014-04-07T07:49:03.951Z|00183|vconn|DBG|unix: sent (Success): 
NXT_PACKET_IN (xid=0x0): cookie=0xa total_len=64 in_port=1 (via action) 
data_len=64 (unbuffered)
mpls,metadata=0,in_port=0,vlan_tci=0x0000,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912
2014-04-07T07:49:03.955Z|00184|vconn|DBG|unix: sent (Broken pipe): 
NXT_PACKET_IN (xid=0x0): cookie=0xa total_len=64 in_port=1 (via action) 
data_len=64 (unbuffered)
mpls,metadata=0,in_port=0,vlan_tci=0x0000,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912
2014-04-07T07:49:03.955Z|00185|rconn|WARN|br0<->unix: connection dropped 
(Broken pipe)