[ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite
Ben Pfaff
blp at nicira.com
Tue Apr 8 18:17:32 UTC 2014
On Tue, Apr 08, 2014 at 09:35:20AM +0900, Simon Horman wrote:
> Uniformly wait for calls to ovs-ofctl exit using
> OVS_APP_EXIT_AND_WAIT() in the test-suite.
>
> Signed-off-by: Simon Horman <horms at verge.net.au>
>
> v2
> * Always use OVS_APP_EXIT_AND_WAIT(ovs-ofctl) instead of
> OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit])
This looks good except that we should always use proper m4 quoting,
e.g.:
OVS_APP_EXIT_AND_WAIT([ovs-ofctl])
instead of
OVS_APP_EXIT_AND_WAIT(ovs-ofctl)
Thanks,
Ben.
More information about the dev
mailing list