[ovs-dev] [PATCH] datapath: Add support for kernel 3.14.

Pritesh Kothari (pritkoth) pritkoth at cisco.com
Tue Apr 8 20:02:14 UTC 2014


On Apr 8, 2014, at 8:54 AM, Thomas Graf <tgraf at redhat.com> wrote:

>>  #endif
>> diff --git a/datapath/linux/compat/include/linux/skbuff.h b/datapath/linux/compat/include/linux/skbuff.h
>> index de0c56a..812ed00 100644
>> --- a/datapath/linux/compat/include/linux/skbuff.h
>> +++ b/datapath/linux/compat/include/linux/skbuff.h
>> @@ -262,6 +262,7 @@ static inline __u32 skb_get_rxhash(struct sk_buff *skb)
>>  unsigned int skb_zerocopy_headlen(const struct sk_buff *from);
>>  void skb_zerocopy(struct sk_buff *to, const struct sk_buff *from, int len,
>>  		  int hlen);
>> +#define skb_get_hash skb_get_rxhash
> 
> and here
> 
> As distributions continue to maintain their own kernel, relying on the
> vanilla kernel release number is somewhat fragile. I realize it's more
> effort to check for definitions but it will produce more reliable code.

Thanks for the review, will make the changes and send in v2.

Regards,
Pritesh




More information about the dev mailing list