[ovs-dev] [PATCH] ofproto-dpif: Remove the flow_dumper thread.

Ben Pfaff blp at nicira.com
Wed Apr 9 16:59:52 UTC 2014


On Wed, Apr 09, 2014 at 04:36:50PM +1200, Joe Stringer wrote:
> Thanks Alex.
> 
> There is also one minor fix to be rolled in:
> 
> @@ -1403,8 +1416,8 @@ revalidate_ukey(struct udpif *udpif, struct udpif_key
> *ukey,
>          compose_slow_path(udpif, &xout, odp_in_port, &xout_actions);
>      }
> 
> -    if (actions_len != xout_actions.size
> -        || memcmp(xout_actions.data, actions, actions_len)) {
> +    if (actions_len != ofpbuf_size(&xout_actions)
> +        || memcmp(ofpbuf_data(&xout_actions), actions, actions_len)) {
>          goto exit;
>      }
> 
> I will wait for further review. Let me know if I should repost.

Repost with the fix and I'll review it.



More information about the dev mailing list