[ovs-dev] [PATCH 1/2] recirc: preserve packet metadata fields for recirculation

Ben Pfaff blp at nicira.com
Wed Apr 9 17:11:02 UTC 2014


On Tue, Apr 08, 2014 at 01:37:04PM -0700, Andy Zhou wrote:
> Packet metadata fields may be modified when execute post recirculation
> actions. Current implementation only preserves recirc_id and dp_hash,
> but not other fields. With this patch, a copy of metadata is supplied
> instead of the original metadata for recirculation to preserve
> the original value.

I think I understand the change here.  Previously, if the actions
executed during recirculation changed metadata fields, then any
actions after the recirculation returns would see those new values.
Now, all metadata are saved and restored across a recirculation.
Right?

Data fields are already saved and restored across recirculation, both
before and after this patch, correct?

Needs a sign-off.

I guess I would prefix the first line as "dpif-netdev:" not "recirc:".

If I'm right about the above:
Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list