[ovs-dev] [PATCH 06/10] ofproto: Probe for masked set action support.

Jarno Rajahalme jrajahalme at nicira.com
Wed Apr 9 20:27:15 UTC 2014


On Apr 9, 2014, at 11:03 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Apr 08, 2014 at 04:38:48PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Does the masked set action cause EINVAL or ERANGE on older kernels.
> Comments say EINVAL in two places, ERANGE in one, and the code
> actually looks for EINVAL.

It would probably be cleaner to use masked actions only when probe succeeds, and keep the old behavior if any error value is returned. It seems I picked up the default case from an existing probe for the userspace action probe for fully considering the desired behavior in this case.

  Jarno




More information about the dev mailing list