[ovs-dev] [PATCH] bridge: improve vlan mode related error messages when adding port

Thomas Graf tgraf at redhat.com
Wed Apr 9 20:47:21 UTC 2014


On 04/09/2014 06:57 PM, Ben Pfaff wrote:
> On Wed, Apr 09, 2014 at 09:52:03AM -0700, Ben Pfaff wrote:
>> On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote:
>>> Inform about fallback to trunk mode and convert errors to warnings
>>> when we are not failing.
>>>
>>> Signed-off-by: Thomas Graf <tgraf at redhat.com>
>>
>> I'm pretty sure that the first one, as the comment says, really can't
>> happen.  Have you been able to trigger it somehow?
>>
>> The second change is OK by me.
>
> On second thought, I'm happy enough with these as warnings, so I
> applied this after touching up line lengths.

I haven't triggered them myself. I came across these while working
on a proposal for ovs-vsctl status.



More information about the dev mailing list