[ovs-dev] [PATCHv8 1/2] tests/ofproto-dpif: Use vlog to test dpif behaviour.

Ben Pfaff blp at nicira.com
Wed Apr 9 23:39:48 UTC 2014


On Thu, Apr 10, 2014 at 11:14:07AM +1200, Joe Stringer wrote:
> From: Joe Stringer <joestringer at nicira.com>
> 
> Previously we made heavy use of the 'ovs-appctl dpif/dump-flows' command
> to verify that flows were being installed into the datapath correctly.
> However this is sensitive to timing, particularly when the behaviour of
> revalidator threads is modified. A common race condition involves flows
> being revalidated and deleted before the test script gets a chance to
> connect to ovs-vswitchd and dump the datapath flows.
> 
> This patch reworks the tests to make use of the vlog facility for dpif,
> checking for flow installation and flow dump messages. Most tests are
> converted to check for flow installation, which should reduce these race
> conditions significantly. For tests that require packet counts, these
> will continue to check for flow_dump messages. Race conditions for these
> should be reduced but not eliminated.
> 
> Signed-off-by: Joe Stringer <joestringer at nicira.com>

Applied, thanks!



More information about the dev mailing list