[ovs-dev] [PATCH] datapath: Orphan frags in skb_zerocopy and handle errors

[Zoltan Kiss]

On 09/04/14 22:52, Jesse Gross wrote:
> On Wed, Apr 9, 2014 at 9:20 AM, Zoltan Kiss <zoltan.kiss at citrix.com> wrote:
>> This is the ported version of commit 36d5fe6a with the same name from net-next.
>> Apart from the small datapath.c changes it adjust the compat layer files as
>> well. This is the original commit message:
>>
>> "skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
>> orphan them. Also, it doesn't handle errors, so this patch takes care of that
>> as well, and modify the callers accordingly. skb_tx_error() is also added to
>> the callers so they will signal the failed delivery towards the creator of the
>> skb."
>>
>> Signed-off-by: Zoltan Kiss <zoltan.kiss at citrix.com>
>
> I think this makes sense as an independent bugfix outside of the 3.14
> patch but can you also provide a backport for skb_tx_error()? I think
> otherwise it won't compile on kernels before 3.8.
>

Indeed, skb_tx_error and skb_orphan_frags need to be stubbed, they don't 
make any sense in kernels older than 3.8.