[ovs-dev] [PATCH 2/5] lib/flow: Add miniflow accessors and miniflow_get_tcp_flags().

Jarno Rajahalme jrajahalme at nicira.com
Fri Apr 18 15:43:45 UTC 2014


On Apr 18, 2014, at 2:28 AM, YAMAMOTO Takashi <yamamoto at valinux.co.jp> wrote:

>> Add inlined generic accessors for miniflow integer type fields, and a
>> new miniflow_get_tcp_flags() usinge these.  These will be used in a
>> later patch.
>> 
>> Some definitions also used in lib/packets.h had to be moved there to
>> resolve circular include dependencies.  Similarly, some inline
>> functions using struct flow are now in lib/flow.h.  IMO this is
>> cleaner, since now the lib/flow.h need not be included from
>> lib/packets.h.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> at least tests/test-sflow.c needs arpa/inet.h for inet_ntop
> as it isn't indirectly included via packets.h anymore.
> 

Added, thanks!

> otherwise looks fine to me.
> 
> Reviewed-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

Pushed to master,

  Jarno




More information about the dev mailing list