[ovs-dev] [PATCH] ofproto-dpif-upcall: Don't use stack garbage

YAMAMOTO Takashi yamamoto at valinux.co.jp
Sun Apr 20 03:52:54 UTC 2014


applied, thanks.

> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> On Apr 17, 2014, at 7:19 PM, YAMAMOTO Takashi <yamamoto at valinux.co.jp> wrote:
> 
>> Catched by "learning action - self-modifying flow with hard_timeout"
>> test case.
>> 
>> The bug introduced by commit b256dc52.
>> ("ofproto-dpif-xlate: Cache xlate_actions() effects.")
>> 
>> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
>> ---
>> ofproto/ofproto-dpif-upcall.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
>> index 0d7dd8e..96a53e6 100644
>> --- a/ofproto/ofproto-dpif-upcall.c
>> +++ b/ofproto/ofproto-dpif-upcall.c
>> @@ -1379,7 +1379,6 @@ revalidate_ukey(struct udpif *udpif, struct udpif_flow_dump *udump,
>>     xoutp = NULL;
>>     actions = NULL;
>>     netflow = NULL;
>> -    may_learn = push.n_packets > 0;
>> 
>>     /* If we don't need to revalidate, we can simply push the stats contained
>>      * in the udump, otherwise we'll have to get the actions so we can check
>> @@ -1413,6 +1412,7 @@ revalidate_ukey(struct udpif *udpif, struct udpif_flow_dump *udump,
>>         goto exit;
>>     }
>> 
>> +    may_learn = push.n_packets > 0;
>>     if (ukey->xcache && !udump->need_revalidate) {
>>         xlate_push_stats(ukey->xcache, may_learn, &push);
>>         ok = true;
>> -- 
>> 1.8.3.1
>> 
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list