[ovs-dev] [PATCH 01/10] lib/flow: Simplify miniflow accessors, add ipv6 support.

Jarno Rajahalme jrajahalme at nicira.com
Mon Apr 21 15:14:18 UTC 2014


On Apr 20, 2014, at 7:49 PM, YAMAMOTO Takashi <yamamoto at valinux.co.jp> wrote:

>> +        hash = mhash_finish(hash, 13); /* No need to match byte length here. */
> 
> is it worth being special?
> 

I’m not exactly sure what you ask here, but in general, the length parameter is used to distinguish between inputs that would otherwise seem the same after being padded to 32-bit length for mash_add(). This is not a concern here, so the actual value of the second parameter to mhash_finish() is inconsequential. 

> YAMAMOTO Takashi

  Jarno


More information about the dev mailing list