[ovs-dev] [PATCH v4 2/2] datapath: use skb_clear_hash instead of skb_clear_rxhash.

[Jesse Gross]

On Tue, Apr 22, 2014 at 2:08 PM, Pritesh Kothari
<pritesh.kothari at cisco.com> wrote:
> diff --git a/datapath/linux/compat/include/linux/skbuff.h b/datapath/linux/compat/include/linux/skbuff.h
> index b0d0190..f47ccfe 100644
> --- a/datapath/linux/compat/include/linux/skbuff.h
> +++ b/datapath/linux/compat/include/linux/skbuff.h
> @@ -280,6 +280,10 @@ int skb_zerocopy(struct sk_buff *to, struct sk_buff *from, int len,
>  #define skb_get_hash skb_get_rxhash
>  #endif
>
> +#ifndef HAVE_SKB_CLEAR_HASH
> +#define skb_clear_hash skb_clear_rxhash
> +#endif

skb_clear_rxhash() was actually a compat function in OVS before it was
upstream, so there is a definition in compat.h that I think should be
moved into skbuff.h and updated.

I actually now also see that skb_get_rxhash(), while not in quite the
same category, already has some macros (for example HAVE_RXHASH) that
could be better integrated with the name changes.

Finally, I'm not sure if this patch should be separate or if can just
be folded into the first one.