[ovs-dev] [PATCH v4 1/2] datapath: Add support for kernel 3.14.

Jesse Gross jesse at nicira.com
Fri Apr 25 19:36:29 UTC 2014


On Fri, Apr 25, 2014 at 12:16 PM, Pritesh Kothari (pritkoth)
<pritkoth at cisco.com> wrote:
> Hi Jesse,
>
>>>
>>> diff --git a/datapath/linux/compat/include/linux/etherdevice.h b/datapath/linux/compat/include/linux/etherdevice.h
>>> index 556729d..c6e8e92 100644
>>> --- a/datapath/linux/compat/include/linux/etherdevice.h
>>> +++ b/datapath/linux/compat/include/linux/etherdevice.h
>>> @@ -34,6 +34,7 @@ static inline int eth_mac_addr(struct net_device *dev, void *p)
>>> }
>>> #endif
>>>
>>> +#ifndef HAVE_ETHER_ADDR_COPY
>>> static inline void ether_addr_copy(u8 *dst, const u8 *src)
>>
>> Now that we have a configure check, I think it is probably cleaner to
>> move this out of the version check.
>
> maybe i am mistaken, but i don’t see any version checks here ?

Sorry, I was mistaken. I thought that the version check from the
previous function continued down to this one.



More information about the dev mailing list