[ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

Martino Fornasa mf at fornasa.it
Mon Apr 28 09:09:06 UTC 2014


Jarno Rajahalme wrote:

> move_rstp() does not check ‘changes’ before clearing it. Consider enforcing the invariant,
> or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
Not clear to me. Function move_rstp does check 'changes':

> move_rstp(struct rstp *rstp )
> {
> int port_no, num_iterations;
> num_iterations = 0;
> while (rstp->changes == true && num_iterations < MAX_RSTP_ITERATIONS) {
>  [...]



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140428/24f238ad/attachment-0005.html>


More information about the dev mailing list