[ovs-dev] [PATCH v4 1/3] Add basic implementation for OpenFlow 1.4 bundles

Ben Pfaff blp at nicira.com
Tue Apr 29 15:13:27 UTC 2014


On Wed, Apr 23, 2014 at 02:03:56PM +0300, Alexandru Copot wrote:
> This is only the communication part of the bundles functionality.
> The actual message pre-validation and commits are not implemented.
> 
> Signed-off-by: Alexandru Copot <alex.mihai.c at gmail.com>

Thanks for the new revision.

I think that ofputil_decode_bundle_add() needs to check the length of
the inner message: it has to be the number of bytes left in the outer
message, or less.

The declaration of OFPRAW_OFPT14_BUNDLE_ADD_MESSAGE in ofp-msgs.h:
    /* OFPT 1.4+ (34): struct ofp14_bundle_add_msg, struct ofp_header, uint8_t[]. */
    OFPRAW_OFPT14_BUNDLE_ADD_MESSAGE,
does not match the declaration of struct ofp14_bundle_add_msg, since
both of them include the inner struct ofp_header.  One of them needs to
be removed.

It would be nice to implement ofputil_encode_bundle_add(), for
completeness.

As long as committing doesn't actually work, I guess that
ofp_bundle_commit() should return an error instead of success.



More information about the dev mailing list